ros2daemon also uses node logger to store log in the file system.#1237
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde what do you think about this fix? i believe there is no downside even if we start the daemon in foreground.
|
Pulls: #1237
|
|
|
windows failures https://ci.ros2.org/job/ci_windows/28198/#showFailuresLink are known issue with spawn_daemon. |
|
i think this is nice to have for downstream distributions, but i suggest wait for a few weeks to make sure nothing breaks in rolling for user experience. |
2 participants
Description
part of #1236.
with this, ros2daemon can also store log file and put the log data on /rosout topic.
Fixes #1236
Is this user-facing behavior change?
Not really, now user can see ros2daemon logfile in ros log directory.
Did you use Generative AI?
Yes, Claude Opus 4.7
Additional Information